Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use quota cache through user management #35308

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

PVince81
Copy link
Member

Fixes #34961

Note: this addresses the "delayed quota" topic from that issue, not the 32-bit one which is separate.

When querying the free space through user management APIs, don't use the cached quota value. The latter is only there to accelerate PROPFINDs.

When querying the free space through user management APIs, don't use the
cached quota value. The latter is only there to accelerate PROPFINDs.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@PVince81
Copy link
Member Author

/backport to stable25

@PVince81
Copy link
Member Author

/backport to stable24

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works! Thanks for fixing! :)

@szaimen szaimen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 21, 2022
@szaimen szaimen merged commit 09345f7 into master Nov 21, 2022
@szaimen szaimen deleted the bugfix/34961/user-mgmt-quota-no-cache branch November 21, 2022 17:39
@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

@szaimen
Copy link
Contributor

szaimen commented Nov 21, 2022

/backport to stable25

@szaimen
Copy link
Contributor

szaimen commented Nov 21, 2022

/backport to stable24

@backportbot-nextcloud
Copy link

The backport to stable24 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable24 failed. Please do this backport manually.

@luddinho
Copy link

Tested and works! Thanks for fixing! :)

Confirm! Fix works fine with both v24 and v25.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: users and groups regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: User Quota can not be changed - revert back to previous value
5 participants